search

haxeui / haxeui-heaps

MIT License
31 stars 12 forks source link

[Style] Addition of the support of background-image-repeat #40

Closed tfabretti closed 1 year ago

tfabretti commented 1 year ago

Linked to the issue #39

The paintTileRepeat function could be shorter but I wanted to avoid having a test for each image to check if it's in the last column/line, in case there are a lot of images to draw. Thus, it's longer but it's supposed to be slightly more optimized (it's probably not noticeable in the extreme majority of use cases, though).

ianharrigan commented 1 year ago

this seems great, one thing, im currently working on fixing the scaling in heaps, and im fairly sure, its going to conflict with this. Hopefully it will be easy to sort out... :/

ianharrigan commented 1 year ago

So yeah, as expected, it conflicts now... :/

Might be easier to just pull latest and reimplement (sorry!)

tfabretti commented 1 year ago

Sure !

tfabretti commented 1 year ago

There was no real conflict, actually, just a simple merge to do ! \o/

ianharrigan commented 1 year ago

Thats reverting my changes though

ianharrigan commented 1 year ago

eg:

image

tfabretti commented 1 year ago

Ah ! My bad, I probably missed something in the VSCode UI, somehow. I'll fix it in a few days, when I'll be back home. Sorry :(

De : Ian Harrigan @.> Envoyé : mercredi 22 mars 2023 16:28 À : haxeui/haxeui-heaps @.> Cc : tfabretti @.>; Author @.> Objet : Re: [haxeui/haxeui-heaps] [Style] Addition of the support of background-image-repeat (PR #40)

Thats reverting my changes though

— Reply to this email directly, view it on GitHubhttps://github.com/haxeui/haxeui-heaps/pull/40#issuecomment-1479779676, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AENQVZ4SZLMYXQOTKBX2Z7TW5MLAPANCNFSM6AAAAAAWDVNIWE. You are receiving this because you authored the thread.Message ID: @.***>