search

haxeui / haxeui-heaps

MIT License
31 stars 12 forks source link

[Style] Addition of the support of background-image-repeat #42

Closed tfabretti closed 1 year ago

tfabretti commented 1 year ago

Hi again ! :D I thought I could delete the branch and add another to the pull request bu it turns out I can't, so i recreated the PR #40 (linked to issue #39) :P Sorry, I'm still struggling with Git and Github :(

ianharrigan commented 1 year ago

Still not sure its right im afraid... in your PR there is code being added for "drawRoundedRect", this was removed and your PR is re-adding it, which makes me cautious about what else it might be re-adding. If i were you it might make sense to close this PR, and make sure you have the most up to date version of haxeui-heaps (which presumably you dont currently), and then "redo" your changes. PITA for sure though... :/

tfabretti commented 1 year ago

Ah ! I made a bad merge, at some point. Then, I didn't check closely enough. Since it was after my new function, I missed it being an entirely other function ^^'

tfabretti commented 1 year ago

I've fixed the merging to make sure I didn't erase some new stuff, it should be alright, now :D

ianharrigan commented 1 year ago

Great, thanks for this! :)