search

haxeui / hxWidgets

Haxe externs (and wrappers) for wxWidgets
MIT License
77 stars 22 forks source link

00-Showcase: Super ugly with dark GTK themes #10

Closed TiZ-HugLife closed 8 years ago

TiZ-HugLife commented 8 years ago

See attached image. I don't know if there's something the sample app has to do or something the bindings have to do, but I figured I'd report anyways. I hope the onslaught of issue submissions are more helpful than annoying. :)

20160210-102216

ianharrigan commented 8 years ago

What happens if you remove this line: https://github.com/ianharrigan/hxWidgets/blob/master/samples/00-Showcase/src/Main.hx#L12

TiZ-HugLife commented 8 years ago

Much better! That's an easy catch, I feel silly for not checking for it myself, haha. 20160210-103202

ianharrigan commented 8 years ago

To be honest, its my fault really i think i just did it to test it worked, ie 0xFF0000 and then just left it there with a different colour... I noticed similar issues on my linux and mac, ie, it wasnt gray but was white and didnt bother to change it.

TiZ-HugLife commented 8 years ago

Well, at least now we know we can do it!

ianharrigan commented 8 years ago

PS: yes, the "onslaught of issues" is certainly helpful - the definite aim hxWidgets is that it will be community driven as generating the full hxWidgets lib externs / wrappers isnt feasible at this time so the more issues and PRs the better in my book.

ianharrigan commented 8 years ago

PPS: im not quite sure how you dont go blind looking at the screen with that theme! :)

TiZ-HugLife commented 8 years ago

It's very relaxing to my eyes, actually. :)

ianharrigan commented 8 years ago

So this is crappy, if you remove that background color from windows: image

TiZ-HugLife commented 8 years ago

That looks like an upstream issue to me.

ianharrigan commented 8 years ago

yeah... Would be nice to somehow fix it though... :/

TiZ-HugLife commented 8 years ago

Probably only a W10 problem. Is it possible to detect W10 and conditionally make the background white?

ianharrigan commented 8 years ago

Ill have to research and see...

ianharrigan commented 8 years ago

Ok, i added PlatformInfo, so can now use: https://github.com/ianharrigan/hxWidgets/commit/0346cf1a91f9f5c47b97bed3e85dd2996a484d54#diff-a1fcf8448c18d2a9b1041ad5e59d5f7eR21

Think this is safe to close?

ianharrigan commented 8 years ago

Subtle, but worth it:

Before: image

After: image

TiZ-HugLife commented 8 years ago

Yeah, that's definitely better, though I'd hazard a guess that not all versions of windows want a white background. I'd probably keep it to 8 or above. Looks like PlatformInfo has code to check that.

ianharrigan commented 8 years ago

Yeah, its just the sample app of course, so i dont think its a major issue to make everything "perfect". Thats more up to anyone writing a "real" application. The important point is that its possible to distinguish between running platforms and modify the UI accordingly.

TiZ-HugLife commented 8 years ago

Fair counterpoint. I'd say we're good here, then.