search

haxeui / hxWidgets

Haxe externs (and wrappers) for wxWidgets
MIT License
77 stars 22 forks source link

Extract the externs into their own package #16

Closed ibilon closed 8 years ago

ibilon commented 8 years ago

I couldn't test the hxcpp compilation for my last commit, should work but I'll report tonight after I check.

All the externs are now in the wx.widgets package, changed from XRef and X to X and XImpl, I put back the cpp::Reference in the @:native since hxcpp can deal with it now, the styles were extracted too.

Haven't touched the hierarchy (#14) yet.

ianharrigan commented 8 years ago

Oh? the cpp::Reference has been fixed?? Where, in hxcpp?

ibilon commented 8 years ago

You can see hugh's comment here https://github.com/HaxeFoundation/hxcpp/issues/359 linking to this commit https://github.com/HaxeFoundation/hxcpp/commit/ab267e10161cc7a9bb2911593531654db1b1dbb7

ianharrigan commented 8 years ago

Nice. Feels "nicer" to be using Refs rather than pointers... Will merge this shortly and check it out. Does this mean hxcpp has be be git version?

ibilon commented 8 years ago

Unsure, will have to test.

Because I modified the way the classes are extended like in Hugh's comment, for instance it's now class CheckBoxImpl extends Window and not class CheckBoxImpl extends WindowImpl, so you don't need the cast anymore actually, so it could work with hxcpp haxelib.

(will have to test too for the cast)

ianharrigan commented 8 years ago

Great, ill check it out on linux and mac later tonight. :+1:

ibilon commented 8 years ago

Ok so my last commit does indeed work, but it does require a git version of hxcpp, the casts were not required so I removed them.

I also moved a couple of classes I forgot.

ianharrigan commented 8 years ago

Ok, great... ill merge it now. I havent had a chance to test it myself, but ill make the assumption it works... :)

ianharrigan commented 8 years ago

So just downloaded and tested... works great... thanks loads @ibilon!