haxeui / hxWidgets

Haxe externs (and wrappers) for wxWidgets
MIT License
77 stars 23 forks source link

Added bindings to TextCtrl #91

Closed Shallowmallow closed 1 year ago

Shallowmallow commented 1 year ago

Added bindings to TextCtrl

ianharrigan commented 1 year ago

yikes! Thanks... lots of api gaps fill in there!

Shallowmallow commented 1 year ago

Most of them aren't really useful to haxeui, but it's always nice to have :)

Le lun. 9 janv. 2023 à 19:15, Ian Harrigan @.***> a écrit :

Merged #91 https://github.com/haxeui/hxWidgets/pull/91 into master.

— Reply to this email directly, view it on GitHub https://github.com/haxeui/hxWidgets/pull/91#event-8184511277, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBNBIQPRN7PBNWIHLL5PDTWRRIV5ANCNFSM6AAAAAATVVOOAM . You are receiving this because you authored the thread.Message ID: @.***>

ianharrigan commented 1 year ago

https://github.com/haxeui/hxWidgets/actions/runs/3876536249/jobs/6610491098

Ill take a look

ianharrigan commented 1 year ago

https://github.com/haxeui/hxWidgets/commit/45972ae6086f8e5f50bc9e5cb9e9475117806cd0

 ::Dynamic TextCtrl_obj::get_selection(){
                HX_STACKFRAME(&_hx_pos_73cec53f5b87b09c_118_get_selection)
HXLINE( 119)         long start = ( ( long)(0) );
HXLINE( 120)         long end = ( ( long)(0) );
HXLINE( 121)         long* startPtr = ::cpp::Pointer_obj::addressOf(start)->get_raw();
HXLINE( 122)         long* endPtr = ::cpp::Pointer_obj::addressOf(end)->get_raw();
HXLINE( 124)        this->get_textCtrlRef()->ptr->GetSelection(startPtr,endPtr);
HXLINE( 125)        return  ::Dynamic(::hx::Anon_obj::Create(2)
                        ->setFixed(0,HX_("start",62,74,0b,84),start)
                        ->setFixed(1,HX_("end",db,03,4d,00),end));
                }

I think the generated cpp looks alright, i could do without the casts, but i can live with it for now. Maybe some smart "abstract" stuff...

Shallowmallow commented 1 year ago

Nice work ! Good idea to have a long extern class . I am understanding haxeui-widgets better and better but I have much yet to learn about C++ ;)

Le lun. 9 janv. 2023 à 20:24, Ian Harrigan @.***> a écrit :

45972ae https://github.com/haxeui/hxWidgets/commit/45972ae6086f8e5f50bc9e5cb9e9475117806cd0

::Dynamic TextCtrl_obj::get_selection(){ HX_STACKFRAME(&_hx_pos_73cec53f5b87b09c_118_get_selection)HXLINE( 119) long start = ( ( long)(0) );HXLINE( 120) long end = ( ( long)(0) );HXLINE( 121) long startPtr = ::cpp::Pointer_obj::addressOf(start)->get_raw();HXLINE( 122) long endPtr = ::cpp::Pointer_obj::addressOf(end)->get_raw();HXLINE( 124) this->get_textCtrlRef()->ptr->GetSelection(startPtr,endPtr);HXLINE( 125) return ::Dynamic(::hx::Anonobj::Create(2) ->setFixed(0,HX("start",62,74,0b,84),start) ->setFixed(1,HX_("end",db,03,4d,00),end)); }

I think the generated cpp looks alright, i could do without the casts, but i can live with it for now. Maybe some smart "abstract" stuff...

— Reply to this email directly, view it on GitHub https://github.com/haxeui/hxWidgets/pull/91#issuecomment-1376165992, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBNBITZPYLLD32P4DJ44YDWRRQXHANCNFSM6AAAAAATVVOOAM . You are receiving this because you authored the thread.Message ID: @.***>

ianharrigan commented 1 year ago

image

back in business :)

Shallowmallow commented 1 year ago

Bravo !! I'm sure you happy to have github actions haha. The good side is that it seems that haxe did improve with versions ( at least on Linux)

Le lun. 9 janv. 2023 à 22:04, Ian Harrigan @.***> a écrit :

[image: image] https://user-images.githubusercontent.com/3024242/211408003-d404a1d3-7f79-48ef-920f-183699430f02.png

back in business :)

— Reply to this email directly, view it on GitHub https://github.com/haxeui/hxWidgets/pull/91#issuecomment-1376311459, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBNBIQXLWTXYJ4IUBYMWB3WRR4NFANCNFSM6AAAAAATVVOOAM . You are receiving this because you authored the thread.Message ID: @.***>

ianharrigan commented 1 year ago

100%