search

haxiomic / firefox-multi-touch-zoom

Smoothly zoom in and out with the multi-touch pinch gesture
MIT License
154 stars 15 forks source link

Double tap to zoom #3

Open mnewt opened 6 years ago

mnewt commented 6 years ago

First, this is amazing! Thanks so much for filling this glaring hole in Firefox.

What do you think about adding a double tap gesture to zoom in and out on a div?

Cheers.

haxiomic commented 6 years ago

Hey @mnewt! I was thinking about this feature and I'd like to add it however I might need to use a different gesture to the two-finger double tap used in Safari and Chrome. Real multi-touch gestures are difficult to access in Desktop Firefox and I don't think I can catch a two finger double tap. A single-finger double tap + shift key may work

Ding-Fan commented 6 years ago

@haxiomic If it's possible, I recommend gesture only with finger(s) on the track pad to zoom in&out. Users are lazy, I won't use this feature if it requires two hands move.😝

theotheroracle commented 6 years ago

make sure not to override the default select behavior if you decide to implement this.

anohren commented 5 years ago

Like OP said, this extension is fantastic!

I have to agree with @Ding-Fan on this one. I think manually zooming and panning to the right place with one hand is more convenient than Shift + two finger double tap with two hands. You'll end up with a convenience feature that is less convenient than its own workaround (i.e. don't throw away your time!)

ezequielp commented 5 years ago

Hi, do you know if there is a ticket on Firefox desktop side to request that they add support for multitouch gestures on extensions?

ALenfant commented 4 years ago

Hii! Love your extension, thanks for the awesome work! I'd be very interested in this feature as well, as it's the one I'm missing the most from Chrome :/

anohren commented 4 years ago

Considering it's possible to activate and test an unfinished native pinch to zoom in the latest builds it might not be worth the effort to polish this plugin further. It doesn't yet support double tap though.

But who knows, Mozilla might take another 10 years to actually finish and ship the feature.

haxiomic commented 4 years ago

A native implementation is best placed to support this (it's much harder to do JavaScript-side). I'm hoping that this feature will be added native zoom not long after it becomes enabled by default, in which case work on this plugin would only be useful for a few months before it's superseded. I've got very little bandwidth free at the moment so I don't have the time to add the feature myself but I'm happy to accept PR's for the feature