search

haxiomic / firefox-multi-touch-zoom

Smoothly zoom in and out with the multi-touch pinch gesture
MIT License
153 stars 15 forks source link

Issues with "new" reddit. #41

Open LRFLEW opened 4 years ago

LRFLEW commented 4 years ago

I have noticed two significant problems when using this add-on with reddit.com and its newer layout. In this layout, posts are presented in-page (still adding to the page history, though), and can be clicked out of to go back. Something about this system is interfering with this add-on. I have noticed two problems specific to this add-on.

  1. On the main page (at least), zooming in on a post can cause it to disappear. This appears to occur specifically when the zoom causes the entire page to fit within a post preview. I think I've seen some similar issues with zooming while on a post page, but I can't find an easily reproducible example.

  2. Every time I go back from looking at a post (either clicking outside of the post or the back button in the browser), the scrolling on the main page gets reset back to the top of the page. This is certainly caused by the add-on, as it occurs when it is enabled, and doesn't when it is disabled.

haxiomic commented 4 years ago

Hey @LRFLEW, in the most recent versions of Firefox native pinch zoom has been added behind a flag :). So this plugin will be retiring in the near future.

To try it out, first disable my plugin, then go to about:config in the URL set apz.allow_zooming to true

Let me know if that works better for reddit!

LRFLEW commented 4 years ago

I did not know about that new option. I was googling it for a while, and the only ones I found were the browser.gesture.pinch.* ones, which don't work well. I tried the new one, and while it felt less "smooth" than this plugin, it did avoid the issues I mentioned. Do you want me to go ahead and close the issue (as a "won't fix, EOL"), or leave it open as it's still an issue with the project itself?