search

haxiomic / firefox-multi-touch-zoom

Smoothly zoom in and out with the multi-touch pinch gesture
MIT License
153 stars 15 forks source link

Blacklist certain websites #44

Open Dyphen opened 4 years ago

Dyphen commented 4 years ago

Tangentially related to #43 - I will try to make a case for a current issue and requested feature. Thank you for your hard work on this great add-on.

Problem Both Multi-Touch Zoom and apz.allow_zooming break when using webapps that incorporate their own multi-touch zoom (usually mimicking ctrl+zoom). Examples of this include Figma and Invision Freehand. And of course, not using either solution removes multi-touch zoom from regular static webpages.

Proposed Feature Allow the user to blacklist a domain so that Multi-Touch Zoom will be effectively disabled on when active. This can be done in the form of a user-input comma separated list in the preference panel, or a toggle in the add-on bar. From what I understand there is no way to domain-scope flags in about:config, and dev on apz.allow_zooming has been moving sluggishly for over a year. As others have also mentioned, Multi-Touch Zoom works better and can incorporate higher level features that the flag cannot.

haxiomic commented 4 years ago

Thanks for reporting @Dyphen Primarily this is because apz zoom and this plugin aren't respecting when the web app wants to override zoom.

I've added an extra check which should help some sites (579735dab068c68dae7464fd6fbd527aef8b312d) and it improves the google maps experience but not figma for some reason

Adding a blacklist is simple enough so I'll find a moment to do this today

Could you repost the issue onto this bug so the people working on the feature see it? https://bugzilla.mozilla.org/show_bug.cgi?id=688990

Progress is slow there but there's definitely people on it

DanStevens commented 4 years ago

Just tried pinch zooming on Google Maps. I noticed that if I don't wait Google Maps UI to finish loading completely and perform a pinch zoom, it breaks. Waiting for everything to finish loading and pinch zoom works fine.

b-d-m-p commented 4 years ago

I would like this feature too. I have to disable the extension on Miro.

jrogov commented 4 years ago

Missing this feature as well. Some sites implement their own gestures for zooming (e.g. app.diagrams.net), and with this extension on top it becomes impossible to use either without explicit disablement of the ext for the whole browser.

@haxiomic Wonder if there's any progress with this? Obstacles, perhaps?