haxiomic / firefox-multi-touch-zoom

Smoothly zoom in and out with the multi-touch pinch gesture
MIT License
154 stars 16 forks source link

Magic Mouse (inertial scrolling) and the shift key #5

Closed ealimonda closed 5 years ago

ealimonda commented 6 years ago

When using the Magic Mouse (or any mouse with inertial scrolling), if you press the Shift key while a scroll action is in progress, you get unwanted zoom events. If this was resolved (i.e. ignoring any shift-scroll events if the shift key wasn't pressed before the scroll started), this addon would be really awesome.

Steps to reproduce:

Either way, it'd be nice to have a setting to disable the shift-scroll functionality, and only zoom with the pinch gesture (because this issue can be triggered even without inertial scrolling, although less frequently)

haxiomic commented 6 years ago

Hey @ealimonda, thanks for reporting – good spot! I'd not noticed the inertial scrolling carries into zoom when you press shift. At the very least I'll add some settings to disable shift-scroll but I'll also see if there's a way to prevent the inertial scroll splitting over

chamini2 commented 5 years ago

close, right?

haxiomic commented 5 years ago

@chamini2 yep, let’s close this now.

Option was added to disable shift scroll in v0.7