search

haxiomic / firefox-multi-touch-zoom

Smoothly zoom in and out with the multi-touch pinch gesture
MIT License
154 stars 16 forks source link

Pinch to zoom does not work #6

Open hackel opened 6 years ago

hackel commented 6 years ago

The pinch to zoom feature doesn't seem to work at all with this extension installed. I can zoom when holding the shift key and scrolling (two-finger dragging) up and down, and it does so smoothly, unlike holding in ctrl without the extension installed, so it does seem to be running. Just not picking up the multi-touch events.

I'm running Firefox 57.0.1 on Ubuntu 17.10 (Xwayland).

haxiomic commented 6 years ago

Hey @hackel, thanks for testing – I've not experimented with Ubuntu setups yet. It could be a setup-specific situation where Firefox is not able to receive the pinch gesture from the OS or it could be a Ubuntu or Linux wide issue.

As a test, does the pinch gesture work on google maps?

Additionally does the pinch gesture work in other browsers (or apps) like Chromium?

theotheroracle commented 6 years ago

you should change the title to "does not work on ubuntu"

retorquere commented 6 years ago

Does that mean there's a linux distro where it would work? I'd change distro just to get pinch-to-zoom back.

vollstock commented 6 years ago

I experience the same behavior on Mac OS 10.13.6 on a MacBook Pro. Works when holdign Shift and scrolling with two finger, behaves like before when pinching and zooming on the trackpad.

haxiomic commented 6 years ago

Hey @vollstock,

Does pinch-to-zoom work on http://maps.google.com ?

I noticed the extension stops working if the APZ.allow_zooming flag is set to true. Check about:config to see what its set to. I think mine got automatically switched to true in an update (on developer edition)

vollstock commented 6 years ago

I have spent some more attention and will try to be more clear.

APZ.allow_zooming is set false. Indeed, ifm I set this to true pinch-zooming stops working.

Anyway I noticed, it actually does work only not as expected.

It still uses the regular zoom-steps and shows them in the address bar. It seems to smoothly scaling inbetween the zoom steps and then reflow the layout once a zoom step is reached. It basically fills the gaps inbetween the regular zoom steps. Does that make any sens to you?

I have attached a video showing the behaviour. In the video I do the following

  1. Pinch-zoomong with addon disabled
  2. Pinch-zooming with addon enabled
  3. Shift-zooming as comparison (=expected, smooth zooming)
haxiomic commented 6 years ago

@vollstock, thanks for the video, In about:config make sure these flags are all empty and not set to something like cmd_...

 browser.gesture.pinch.in
 browser.gesture.pinch.in.shift
 browser.gesture.pinch.out
 browser.gesture.pinch.out.shift

I think someone recommended using them in conjunction with this plugin, however it's not the right thing to do for smooth zoom – they should be unset

vollstock commented 6 years ago

You are right, those were set:

bildschirmfoto 2018-08-21 um 11 27 25

I don’t know why, though. I’m pretty sure, I have never touched them.

I tnow seems to work just fine :) Thanks!

durka commented 6 years ago

~I'm on macOS 10.13.4, Firefox 61.0.2. Pinch-to-zoom doesn't work anywhere, including Google Maps. Shift-scroll works everywhere including maps. I know pinching worked when I installed this plugin, but I don't know when exactly it stopped working. I checked the about:config settings and they are all correct according to your recommendations.~

Edit: the "pinch-to-zoom" setting was turned off in OS touchpad settings.

haxiomic commented 6 years ago

Hey @durka, sorry for the slow response; was AFK the last week

Thanks for reporting your issue and updating it – hopefully it'll help other people with the same problem :)

Good to hear it's working now

lubyrex commented 4 years ago

Hi @haxiomic, I'm using Gnome on Wayland on debian. I have been trying out different browsers to search for the pinch to zoom feature. Then I came across this plugin and it works perfectly if I use shift + scroll, but I don't know how to enable pinch to zoom(pinching does nothing right now). And pinching doesn't work on google map in firefox either. Pinch to zoom only works on the native gnome web browser. Any chance I could do some set up somehow to enable the pinch to zoom? Thanks

haxiomic commented 4 years ago

Hey @lubyrex, unfortunately if pinch-zoom isn't working in google maps in chrome or firefox then this plugin wont work (it uses the same input events that maps uses)

Sounds like the drivers are working but pinch information isn't being passed to chome / firefox – you may just have to search around to see if anyone has managed to get chrome and firefox pinch working with your setup