search

haxpax / gosms

:mailbox_closed: Your own local SMS gateway in Go
GNU General Public License v2.0
1.45k stars 154 forks source link

Minor improvements #9

Closed analogic closed 7 years ago

analogic commented 7 years ago

Made modem.go compatible with siemens MC75, extended methods to allow future SMS reading (will do in couple days). Added optional http basic auth. (all changes should not cause any problems to current installations)

Omie commented 7 years ago

hey @analogic, thanks for the pr. Neither of me and @madhurjain has bandwidth to maintain this project. I will merge the changes as long as they look good enough just after reading the code :) Could you please add contributors.txt and your name as contributor in it? You may just update the readme with the same if you feel like!

analogic commented 7 years ago

I will add credits next time since I need catch incomming sms also. So I will definitely continue to work on this project :)

Omie commented 7 years ago

that would be another PR, right? should I merge and close this one?

analogic commented 7 years ago

Yep, it is up to you but sure you can. :)