search

haxpor / aseprite-macos-buildsh

Automated script to create latest release app (either beta, or release whichever is newer) of Aseprite for macOS
MIT License
156 stars 42 forks source link

Use latest release from beginning #16

Closed klep closed 3 years ago

klep commented 3 years ago

The branch master no longer exists in the repo -- it has been renamed main. However, I think we're better off using the latest tag, since that's what's used later when we do the final build.

haxpor commented 3 years ago

@klep I did check and upstream aseprite changed git branch structure to hold normal release (stable version), and beta version into separate branch. They are respectively main, and beta branches now.

I believe we would need to modify aseprite.sh to allow users to explicitly choose whether they want stable or beta version to build. Overall git related commands in aseprite.sh will still be fine but especially we will checkout a proper branch (either main or beta) then existing command of 

git checkout `git describe --tags`

will return a correct result for the latest recent tag corresponding to which branch such tag coming from. Now it return unexpected tag.

Do you want to work on this yourself or I can do it from my side? regarding to the following changes

  1. Accept command line argument of --beta, but by default we will build against normal stable release via main branch.
  2. Change accordingly to git related command to checkout a proper branch as we knew user's intent from 1.
  3. Cleanup misc URL that still bases on master, or adjust accordingly.

Feel free to let me know! Thanks!

klep commented 3 years ago

Happy to handle it either way. I suspect this isn't a full time focus for either of us, so maybe just whomever gets to it first? I'll have some in a few weeks, but won't be offended if you make the fix without me :)

haxpor commented 3 years ago

Thanks @klep . I asked to respect your initiation, and continued effort in making changes. I'll do it but will mention and link in your finding/effort in the commit message. Thank you again :)

I close this issue for now. The proper fix will be worked on later.

haxpor commented 3 years ago

This can be tracked at https://github.com/haxpor/aseprite-macos-buildsh/issues/17