search

haxtheweb / issues

Issue queue for hax, haxcms, elmsln, lrnwebcomponents, wcfactory, websites and more.
Apache License 2.0
11 stars 1 forks source link

test php 8.x support; ensure 7.x.x support as well #1446

Closed btopro closed 2 weeks ago

btopro commented 1 year ago

rolling 7.4 currently on LTS systems / ddev

btopro commented 1 month ago

Deprecated: Return type of DirFilter::getChildren() should either be compatible with RecursiveFilterIterator::getChildren(): ?RecursiveFilterIterator, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/system/backend/php/lib/HAXCMS.php on line 1708

Deprecated: Return type of DirFilter::accept() should either be compatible with FilterIterator::accept(): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/system/backend/php/lib/HAXCMS.php on line 1704

the above were fixed w/ an update to the iterator implementation

btopro commented 1 month ago

https://github.com/php/php-src/blob/e4e2541c1a90daf708ab1ee4d44f2ab2883ce84b/UPGRADING#L515-L520

this is missing so sitemap fails hard

btopro commented 1 month ago

https://markbakeruk.net/2020/11/17/under-the-radar-a-backwards-compatible-break-for-splfixedarray-in-php-8/ has clues as well

btopro commented 1 month ago

https://spencermortensen.com/articles/php-error-handling/