haxwell / quizki

A question and answer database that generates exams.
http://www.quizki.com
GNU General Public License v2.0
4 stars 14 forks source link

Issue #192 GitHub logo #195

Closed jdisser closed 6 years ago

jdisser commented 6 years ago

In addition to adding the github reference this request includes modifications to the .gitignore file to remove the project related files and directories from the repo. Because they were previously tracked simply altering the .gitignore file would not remove them from the project. They also needed to be removed from the local index using git rm -r --cached some-directory (to remove directories and contents) git rm --cached /path/to/file (to remove files) and once removed the changes to the .gitignore were added and committed. I did not pull the most recent version of master thinking that it might complicate and interfere with the removal of the project files, but I did check it and see that there would be no conflicts. The file QuestionViewItemChoice.html was inadvertently changed while getting familiar with the IDE and a 2nd change was made to restore it to as it currently appears in Haxwell/master

haxwell commented 6 years ago

Okay, so I did it a little backwards, and read your opening comments after I reviewed your code :)

You will want to redo this pull request, splitting it in two with IDE related changes in one PR, and the Github logo changes in another. Also, regarding QuestionChoiceItemView, etc, there should never be extraneous changes in a Pull Request... Next time that happens, you should clean up/revert those changes before submitting your PR.

You may find it easier to just pull the repo again, and re-do your changes in that clean repo. Let me know if you need a hand. Also, use the dev branch rather than master.

jdisser commented 6 years ago

Thanks, will redo on a dev branch with a fresh pull.

jdisser commented 6 years ago

I reloaded the project with a new clone and fork. I'll generate the pull request for the github reference from the new repo