Change to constants in file: question-views.js

[BrianHCombes]

cq.addChoice method calls were located in the question-views.js file. The addChoice method expression was located in the file: question.js. The arity of the addChoice method is larger than the three arguments passed to it from the cq.addChoice method calls. By inspection only the second and third arguments are applicable for this update.

The constants were declared using the const key word per the guidelines in ECMASCRIPT 6. The intent is to make the constants immutable otherwise an error is thrown if an attempt is made to change the value.

The declarations are made at the top of the file. It is assumed the constants are intended to be have (entire file) block-scope level bindings.

The constant declared are:

const SEQUENCE_0 = "0"; const IS_CORRECT = true; const NOT_CORRECT = false;

The appropriate substitutions were made in the cq.adChoice method calls. See lines in and around line number 845 in question-views.js

Additional Comments to Submit:

It is noted after an initial round of constant declarations and substitutions, additional substitutions were needed regarding the aforementioned constants of:

const SEQUENCE_0 = "0"; const IS_CORRECT = true; const NOT_CORRECT = false;

The the additional substitutions were performed in file question-views.js at roughly lines: 818, 821, and 869. The substitution at line 869 was only partial due to a conditional expression representing the second argument and was thus left as is.

Additionally, the appropriate aforementioned declarations were also made in file: question.js for a substitution at roughly line 154 in that file.

[haxwell]

Note to present and future selves: Brian is going to create a single Pull Request with changes related to this issue. So, closing this.