haxxnz / nzcp-js

A verification library for COVID-19 Vaccine Passes in New Zealand

MIT License

37 stars 7 forks source link

Added detailed error messages for validateCovidPass function #14

Closed J-eld closed 3 years ago

J-eld commented 3 years ago

Fixes #6

Please review to check if error messages are valid and correct

[x] Tests pass
[ ] Appropriate changes to README are included in PR

wseagar commented 3 years ago

Hey J-eld thank you so much for contributing - We're just working on the the API for this and I think we've settled with a different data structure to return for errors. @noway is working on it now but when were settled we'll be happy to keep working on this.

J-eld commented 3 years ago

No worries, thanks for letting me know. I'm new to open source but keen to contribute where I can. I'll keep an eye on the issues tab for anything I feel like I can contribute to.

wseagar commented 3 years ago

Decided to go for a different structure than referenced in the issue, it should be in now. I've got another task you can work on @J-eld I'll tag you in the issue

wseagar commented 3 years ago

19 @J-eld do you want to take this ticket?