haxxnz / nzcp-js

A verification library for COVID-19 Vaccine Passes in New Zealand
MIT License
36 stars 7 forks source link

Legit pass fails the test #43

Closed noway closed 2 years ago

noway commented 2 years ago

We're getting reports that legit passes fail the tests. Can we get our hands on one?

noway commented 2 years ago
{
  "iss": "did:web:nzcp.identity.health.nz",
  "nbf": 1651665600,
  "exp": 1636023600,
  "vc": {
    "@context": [
      "https://www.w3.org/2018/credentials/v1",
      "https://health.govt.nz/credentials/cpnz"
    ],
    "version": "1.0.0",
    "type": [
      "VerifiableCredential",
      "PublicCovidPass"
    ],
    "credentialSubject": {
      "givenName": "..",
      "familyName": "..",
      "dob": "yyyy-mm-dd"
    }
  }
}

That is how a legit pass will look

wseagar commented 2 years ago

I think the issue is reported from Raf's site https://vaxxed.as which is still pointing to the test issuer, all he needs to-do it change it to using the real issuer and our main interface. (I think)

rafcontreras commented 2 years ago

This can be closed, it was the wrong issuer.

zerkms commented 2 years ago

The one I just issued at mycovidrecord fails with

{
  "success": false,
  "credentialSubject": null,
  "violates": {
    "message": "notFound",
    "link": "https://nzcp.covid19.health.nz/#ref:DID-CORE",
    "section": "DID-CORE.1"
  }
}

(using the https://codesandbox.io/s/nzcpjs-demo-4vjgb as a library runtime)

upd: it's weird, but vaxxed.as scans fine

noway commented 2 years ago

vaxxed.as uses hard-coded DID document at the moment. For this to be resolved we're waiting for MoH to fix the CORS issue. They are on it.