Shoutrrr validation fails for ntfy:// URLs despite tests succeeding - Githubissues

hay-kot / homebox

Homebox is the inventory and organization system built for the Home User

https://hay-kot.github.io/homebox/

GNU Affero General Public License v3.0

2.64k stars 190 forks source link

Shoutrrr validation fails for ntfy:// URLs despite tests succeeding #590

Closed chessmango closed 10 months ago

chessmango commented 11 months ago

First Check

[X] This is not a feature request
[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the documentation, with the integrated search.
[X] I already read the docs and didn't find an answer.

Homebox Version

0.10.1

What is the issue you are experiencing?

Homebox fails to validate ntfy:// URL prefix when creating a notifier. Tests succeed, so it seems Shoutrrr is up to date.

How can the maintainer reproduce the issue?

Attempt to create a ntfy.sh notifier using ntfy:// as a prefix

Deployment

Docker (Linux)

Deployment Details

No response

chessmango commented 10 months ago

An alternative option here would be to allow any (reasonable) string as a notification target, but require a test to succeed in order to save it. Shoutrrr can then add new supported schemes without any maintenance requirement here. Thoughts?