Closed hay-kot closed 3 months ago
@izeau - I made some changes on top of your PR. Mostly just preference/style things. Let me know if you have any thoughts!
Well that's really great - and a bit humbling if I'm being honest. I'm thankful that you took the time to review and improve this, and sorry you had to rework it that much!
and a bit humbling if I'm being honest
I wouldn't feel too bad. Really the only thing I changed that wasn't a 'same thing but my way' kind of change was the matching prefixes thing. everything else you wrote was perfectly fine!
Notable Changes from Original PR
Also See
154