search

hay / stapes

the Javascript MVC microframework that does just enough
http://hay.github.io/stapes
MIT License
443 stars 54 forks source link

Fixes #61 - subclass does not copy static methods #63

Closed foxx closed 9 years ago

foxx commented 9 years ago

Fixes #61, subclassing will now copy any static methods added by extend. I've also added some helper commands which make local testing easier, and amended the unit tests accordingly.

I have not updated the .min.js file, as I'm not sure which minifier you preferred to use, or any optimisations that you may usually apply. Plus this would have to be regenerated at the point of merge anyway, for sanity etc.

From what I can tell, this PR does not cause any regressions, however I'm in the process of adding automated multiple platform testing, which I've raised in #62. I'd recommend not merging this PR until I've submitted the results of these tests (which will be in the next few hours)

foxx commented 9 years ago

This should now be safe for merge. Unit tests passed on the following browsers;

Chrome latest on Windows 7 Firefox latest Android emulator 4.4 Safari 8.0 on Yosemite iPhone simulator 8.2 on Yosemite IE 11 on Windows 8.1 IE 10 on Windows 7 IE 9 on Windows 7

hay commented 9 years ago

See comment on #61. This is the intended behaviour of extend.