haya14busa / vim-easymotion

DEPRECATED
https://github.com/Lokaltog/vim-easymotion
23 stars 0 forks source link

Collaborator on the Lokaltog/vim-easymotion repo #12

Closed Lokaltog closed 10 years ago

Lokaltog commented 10 years ago

I don't plan on working on the vimscript version of easymotion or other features in the foreseeable future as I've migrated to emacs and rarely use vim anymore. Instead of me merging your fork into my repo, I could add you as a collaborator so you can push your updates to the main repo instead of your fork so all existing users of easymotion can benefit from your updates. Let me know what you think!

haya14busa commented 10 years ago

Instead of me merging your fork into my repo, I could add you as a collaborator so you can push your updates to the main repo instead of your fork

Oh, really? I'm ok to work as a collaborator and it's better considering all existing users of easymotion and respect to your work. I implemented & improved a lot of new features but I carefully considered backward compatibility, so maybe it's easy for the users to update easymotion.

Question: Do you mind if I'll develop easymotion freely?

I carefully considered backward compatibility, but I modified coding style and implemented many motions which could be against easymotion concept.

Off-screen n key motion sample gif:

recorded

scrolling by <Tab> key

Lokaltog commented 10 years ago

Absolutely, I think many of the changes and updates in your fork look awesome. I'll add you as a collaborator right away so you can push your updates to the main repo.

haya14busa commented 10 years ago

I'll add you as a collaborator right away so you can push your updates to the main repo.

Thanks! I'll modify README, help doc, and a little code for adjusting to your repo before pushing the main repository, so please wait a little.

One more question. Would you mind if I'll add description about me at the top or bottom of README?(like powerline)

If you won't touch the code nor respond issue anymore, I think I could say I'm not a mere collaborator but a second(?) author. If I work as a collaborator at Lokaltog/vim-easymotion without the description about me, my motivation for easymotion will definitely become down.

Lokaltog commented 10 years ago

Of course, I thought it was implied that you can list yourself as an author if you're taking over development of the project. You could just duplicate the header part from powerline or something like that and add yourself as an author on top of the readme?

Kim Silkebækken

On 29. jan. 2014, at 03:51, haya14busa notifications@github.com wrote:

I'll add you as a collaborator right away so you can push your updates to the main repo.

Thanks! I'll modify README, help doc, and a little code for adjusting to your repo before pushing the main repository, so please wait a little.

One more question. Would you mind if I'll add description about me at the top or bottom of README?(like powerline)

If you won't touch the code nor respond issue anymore, I think I could say I'm not a mere collaborator but a second(?) author. If I work as a collaborator at Lokaltog/vim-easymotion without the description about me, my motivation for easymotion will definitely become down.

— Reply to this email directly or view it on GitHub.

haya14busa commented 10 years ago

I'm relieved to hear that. I could actively develop or maintain easymotion.

In addition, maybe last favor, I want you to sync Lokaltog/vim-easymotion repo to Travis CI because I added test in my fork version.

Thanks again!

haya14busa commented 10 years ago

Probably I could push to Lokaltog/vim-easymotion repo this weekend.

I have modified README & help doc and separated some 'operator' like motion(e.g. SelectLine which is implemented by supasorn)

https://github.com/haya14busa/vim-easymotion/tree/adjust/lokaltog

I'll confirm whether it works well and do not break backward compatibility before merge it.

Thanks.

haya14busa commented 10 years ago

I pushed the updates to the main repo just now, so please see it and I want you to sync repo to Travis CI because I don't have permission.

Thanks

haya14busa commented 10 years ago

@Lokaltog Please sync Lokaltog/vim-easymotion repo to Travis CI. Just a few clicks.

Thanks.

Lokaltog commented 10 years ago

Sorry about the delay, I've enabled Travis now.

haya14busa commented 10 years ago

Thank you, @Lokaltog !