search

haya14busa / vim-easymotion

DEPRECATED
https://github.com/Lokaltog/vim-easymotion
23 stars 0 forks source link

Nice work on the new revision! #15

Open supasorn opened 10 years ago

supasorn commented 10 years ago

This is pretty well thought-out. And thanks for merging the work. I was planning to merge to the Lokaltog at some point but never had time to complete the remaining features and code clean-up. I do have some experimental features planning on my fork, but still don't have much time currently. Anyway, this is a great work! p.s. some reference or note to my fork would be appreciated

haya14busa commented 10 years ago

This is pretty well thought-out

Thanks! :)

i was planning to merge to the lokaltog at some point

I pushed the updates including your work to the Lokaltog/vim-easymotion just yesterday, so please see it. Actually, I became collabolator on Lokaltog/vim-easymotion, so this haya14busa/vim-easymotion repository is depricated and I'll work on the main Lokaltog's repository.

I do have some experimental features planning on my fork

Oh, really? I long for your new works!

p.s. some reference or note to my fork would be appreciated

I noted on help document that two-key combo & bi-directional features are based on your work, but on second thought, I should have noted on reademe too? I'm sorry. I'll add the description for your work.

supasorn commented 10 years ago

Oh I see. I'm happy someone is actively maintaining the fork! A note on vim-easyoperator-line is that, when yl or dl are used, the current cursor should move back to where it was before the command is issued. So users won't have to press g;

haya14busa commented 10 years ago

A note on vim-easyoperator-line is that, when yl or dl are used, the current cursor should move back to where it was before the command is issued. So users won't have to press g;

Yeah, I know this problem, but if you map by yourself like nmap d<leader>l <Plug>(easyoperator-line-delete), the cursor will automatically move back.

The problem is, actually, <Plug>(easymotion-prefix) doesn't expand (or remap) if it is used in lhs, so I can't map it by default. Example:

map <Plug>(easymotion-prefix) <Leader>
" Do not work...
nmap d<Plug>(easymotion-prefix)l <Plug>(easyoperator-line-delete)
" It works well
nmap d<Leader>l <Plug>(easyoperator-line-delete)

The easy solution is using global variable to map as before, but I won't do it.

I'll try to find another solution or make the users map them by themselves by default.