Apparent problem with certain special characters in File/ Youtube Video name

[cirwin518]

New to your app, very happy with it so far.

I have had an instance happen twice where a file throws an error. After some very rough testing it seems like its related to the Colon in each title.

I got the following error with this URL: https://youtu.be/qQ84delhpuw

Traceback:

File "C:\Users\carter\AppData\Local\Programs\Python\Python310\lib\site-packages\streamlit\runtime\scriptrunner\script_runner.py", line 565, in _runscript exec(code, module.dict) File "E:\github\whisper-ui\app\01🏠_Home.py", line 71, in media_manager.add( File "E:\github\whisper-ui\app\core.py", line 165, in add self._create(source_list=source_list, source_type=source_type, **whisper_args) File "E:\github\whisper-ui\app\core.py", line 117, in _create yc.streams.get_by_itag(140).download(save_dir, filename=save_filename) File "C:\Users\carter\AppData\Local\Programs\Python\Python310\lib\site-packages\pytube\streams.py", line 298, in download file_path = self.get_file_path( File "C:\Users\carter\AppData\Local\Programs\Python\Python310\lib\site-packages\pytube\streams.py", line 349, in get_file_path return os.path.join(target_directory(output_path), filename) File "C:\Users\carter\AppData\Local\Programs\Python\Python310\lib\site-packages\pytube\helpers.py", line 254, in target_directory os.makedirs(output_path, exist_ok=True) File "C:\Users\carter\AppData\Local\Programs\Python\Python310\lib\os.py", line 225, in makedirs mkdir(name, mode)

Similar issue with this URL: https://youtu.be/uYI1PpMElgM

Traceback:

File "C:\Users\carter\AppData\Local\Programs\Python\Python310\lib\site-packages\streamlit\runtime\scriptrunner\script_runner.py", line 565, in _runscript exec(code, module.dict) File "E:\github\whisper-ui\app\01🏠_Home.py", line 71, in media_manager.add( File "E:\github\whisper-ui\app\core.py", line 165, in add self._create(source_list=source_list, source_type=source_type, **whisper_args) File "E:\github\whisper-ui\app\core.py", line 117, in _create yc.streams.get_by_itag(140).download(save_dir, filename=save_filename) File "C:\Users\carter\AppData\Local\Programs\Python\Python310\lib\site-packages\pytube\streams.py", line 298, in download file_path = self.get_file_path( File "C:\Users\carter\AppData\Local\Programs\Python\Python310\lib\site-packages\pytube\streams.py", line 349, in get_file_path return os.path.join(target_directory(output_path), filename) File "C:\Users\carter\AppData\Local\Programs\Python\Python310\lib\site-packages\pytube\helpers.py", line 254, in target_directory os.makedirs(output_path, exist_ok=True) File "C:\Users\carter\AppData\Local\Programs\Python\Python310\lib\os.py", line 215, in makedirs makedirs(head, exist_ok=exist_ok) File "C:\Users\carter\AppData\Local\Programs\Python\Python310\lib\os.py", line 225, in makedirs mkdir(name, mode)

[cirwin518]

I had similar issues using this with files with "%" in the file name, and it was resolved when I modified the file name to remove the characters.

[hayabhay]

Thanks for the flag! This was most definitely a bug on my end. I've updated it with a fix. This should remove all special characters from the directories that get created :)

If it acts up, don't hesitate to raise another issue!

[cirwin518]

Great job! Thanks for the update.

Im a little new to python but I work as a project manager full time for a small startup, so if you ever need to bounce ideas or need some investigative bug testing feel free to reach out.

I may be replying at a time that is convenient for me, however, I don’t expect you to reply outside of your working hours.

[cid:32483ca3-467a-4037-8d4c-3c864c102358]

Carter Irwin

Director of Technology

Innovations Accelerator

D: +1 518. 526.8199

@.***

www.weGatherInteractive.com

[cid:8d5c1c7a-46c5-496a-81f0-86caa39acc3c]

---

From: Abhay Kashyap @.> Sent: Wednesday, February 8, 2023 1:45 PM To: hayabhay/whisper-ui @.> Cc: Carter Irwin @.>; Author @.> Subject: Re: [hayabhay/whisper-ui] Apparent problem with certain special characters in File/ Youtube Video name (Issue #16)

Thanks for the flag! This was most definitely a bug on my end. I've updated it with a fix. This should remove all special characters from the directories that get created :)

If it acts up, don't hesitate to raise another issue!

— Reply to this email directly, view it on GitHubhttps://github.com/hayabhay/whisper-ui/issues/16#issuecomment-1423080525, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASR5SQJM35IMOQS7ZPAFZNTWWPSTFANCNFSM6AAAAAAUVS66ZY. You are receiving this because you authored the thread.Message ID: @.***>

This message, and any attachments, is for the intended recipient(s) only, may contain information that is privileged, confidential and/or proprietary. If you are not the intended recipient, please delete this message.