search

hayamiz / twittering-mode

An Emacs major mode for Twitter
http://twmode.sourceforge.net/
545 stars 92 forks source link

a bug handling the response from twitter #71

Open nicferrier opened 11 years ago

nicferrier commented 11 years ago 
diff -c /home/nferrier/.emacs.d/elpa/twittering-mode-2.0.0/twittering-mode.el.\~1\~ /home/nferrier/.emacs.d/elpa/twittering-mode-2.0.0/twittering-mode.el
*** /home/nferrier/.emacs.d/elpa/twittering-mode-2.0.0/twittering-mode.el.~1~   2013-06-03 12:53:00.374889823 +0100
--- /home/nferrier/.emacs.d/elpa/twittering-mode-2.0.0/twittering-mode.el   2013-06-03 13:21:03.222932578 +0100
***************
*** 2022,2028 ****
        ;; utf-8 as one of acceptable charset.
        ;; For the present, only UTF-8 is taken into account.
        (let* ((content-type (cdr (assoc "Content-Type" header-info)))
!        (parameters (cdr (split-string content-type ";")))
         (regexp "^[[:space:]]*charset=utf-8[[:space:]]*$")
         (encoded-with-utf-8
          (let ((case-fold-search t))
--- 2022,2028 ----
        ;; utf-8 as one of acceptable charset.
        ;; For the present, only UTF-8 is taken into account.
        (let* ((content-type (cdr (assoc "Content-Type" header-info)))
!        (parameters (when content-type (cdr (split-string content-type ";"))))
         (regexp "^[[:space:]]*charset=utf-8[[:space:]]*$")
         (encoded-with-utf-8
          (let ((case-fold-search t))

that's my diff to fix it.

Based on the marmalade version.

I'd be happy to contribute fixed to twittering-mode... is this github the right place to do it?

cvmat commented 11 years ago

The Marmalade version is so old and seems not to be updated. And I do not own the package http://marmalade-repo.org/packages/twittering-mode .

The bug has been fixed on the 3.0.0 and the GitHub version. I recommend the GitHub version (the latest), the MELPA version (periodically synchronized with the GitHub version) or the sourceforge version (recently updated into 3.0.0).

nicferrier commented 11 years ago

Ok. I run marmalade-repo - would you update it there if you owned the package?

If you register a user on marmalade-repo I will assign ownership of the package to you.

cvmat commented 11 years ago

I am sorry for late response. If no one will do it, I will do it. However, I do not know the rules and conventions of Marmalade. I will update the package after studying them. I did not know even the fact that a package could have multiple 'owners', until reading the API manual http://marmalade-repo.org/doc-files/api.7.html#POST-v1-packages-package-owners today...

In addition, I want to limit the official upstream to the GitHub repository and the sourceforge page. I do not have so much time for managing many channels.

If possible, automatic or periodic synchronization with the sourceforge http://twmode.sourceforge.net/ or the 3.0.x branch on GitHub https://github.com/hayamiz/twittering-mode/tree/3.0.x is better for me.