search

hayamiz / twittering-mode

An Emacs major mode for Twitter
http://twmode.sourceforge.net/
545 stars 92 forks source link

defcustom/defgroup addition & menubar #76

Open ayman opened 10 years ago

ayman commented 10 years ago

Adding defcustom and defgroup for easy config and adding a pretty menubar menu.

image

voidlily commented 9 years ago

+1

xmaillard commented 9 years ago

Oh ! I did not pay attention enough. There is great stuff into your patch too.

Maybe we should try to converge our 2 patches. Yours with easymenu support would be greatly appreciated !

ayman commented 9 years ago

Converge would be best IMHO - but the menubar stuff is easy to rip out into a second request of there's no defcustom stuff of mine that you want to use.

On Mon, Jan 5, 2015 at 2:32 AM, Xavier Maillard notifications@github.com wrote:

Oh ! I did not pay attention enough. There is great stuff into your patch too.

Maybe we should try to converge our 2 patches. Yours with easymenu support would be greatly appreciated !

— Reply to this email directly or view it on GitHub https://github.com/hayamiz/twittering-mode/pull/76#issuecomment-68691198 .

xmaillard commented 9 years ago

I am trying to clean up my patch and submit it again. Maybe you could then try to rebase your work on it ?

Regards

ayman commented 9 years ago

Thanks. I'll work on a rebase and update soon.

ayman commented 9 years ago

Updated things - pull request just adds menubar functionality and the :prefix "twittering-" to the defgroup.

cvmat commented 8 years ago

Thank you for your contribution. I am sorry to have kept you waiting. I have commited your patch as hayamiz/twittering-mode@0ed680567d2e346e95dbf195f485f2155b00c67a and fixed it as hayamiz/twittering-mode@44854d9052577b43ea4f92b6ec62e7ea9db49d9b .