search

hayd / deno-udd

Update Deno Dependencies - update dependency urls to their latest published versions
MIT License
329 stars 18 forks source link

Parse modifiers in versions #101

Closed sigmaSd closed 1 year ago

sigmaSd commented 1 year ago

Fix https://github.com/hayd/deno-udd/issues/96

I personally would expect that ~6.6.0 becomes ~6.6.6 (tilde) remain, but I saw that there are tests in the codebase that expect the modifier stripped.

sigmaSd commented 1 year ago

But I don't get the whole switching the modifier position part , it seems to cause subtle issues like https://github.com/hayd/deno-udd/issues/88 https://github.com/hayd/deno-udd/issues/58

sigmaSd commented 1 year ago

Tilde and caret parsing seems incomplete though https://github.com/hayd/deno-udd/blob/master/semver.ts#L38 that probably need to be fixed for this pr to work reliably

sigmaSd commented 1 year ago

std semver has https://deno.land/std@0.166.0/semver/mod.ts?s=satisfies which should handle this

sigmaSd commented 1 year ago

closed in favor of https://github.com/hayd/deno-udd/pull/102