search

hayd / pep8radius

PEP8 clean only the parts of the files touched since the last commit, a previous commit or (the merge-base of) a branch.
MIT License
183 stars 9 forks source link

ENH add bazaar #53

Closed hayd closed 10 years ago

hayd commented 10 years ago

rebase of #37. Still with the same issues...

coveralls commented 10 years ago

Coverage Status

Coverage decreased (-1.77%) when pulling 4f5d4a8ac6f61b443bd5684adea250bd5e017be3 on add_bzr2 into bb3c954c806fa4e8f3b4607910c8c0e08bc9d911 on master.

coveralls commented 10 years ago

Coverage Status

Coverage increased (+0.9%) when pulling 56cc324de8662dbdf521c55b55c106931a6bd302 on add_bzr2 into bcfec0be0efec563e897289bde2f7fbc76ec367d on master.

hayd commented 10 years ago

@schodge I pushed some quieting in the tests here (as I thought I was just about to merge it).

(Note to self, I need merge-base to check it's a branch and if not just diff against rev - really can't be bothered atm though, bzr=awful.)

hayd commented 10 years ago

@schodge My gut is to merge this branch and then fix up, windows and branches etc. I thought I had a branch with a refactor similar to yours using a simpler shell_out function (which I thought was pretty nice) rather than check_output or your (too :p) clever context manager.

This project has been in flux too long!!

schodge commented 10 years ago

Pick whatever solution you like and I'll adapt my code accordingly. I haven't wanted to make arch changes to your code.

Non-ideal input device. Please excuse typos. On Jul 30, 2014 1:24 PM, "Andy Hayden" notifications@github.com wrote:

@schodge https://github.com/schodge My gut is to merge this branch and then fix up, windows and branches etc. I thought I had a branch with a refactor similar to yours using a simpler shell_out function (which I thought was pretty nice) rather than check_output or your (too :p) clever context manager.

This project has been in flux too long!!

— Reply to this email directly or view it on GitHub https://github.com/hayd/pep8radius/pull/53#issuecomment-50674389.

coveralls commented 10 years ago

Coverage Status

Coverage increased (+1.61%) when pulling 93b996d7dafd519c9ca8fae4b1c816a81858d8c3 on add_bzr2 into bcfec0be0efec563e897289bde2f7fbc76ec367d on master.

hayd commented 10 years ago

lolz, ok had to switch to nosetests rather than py.test, one last bug is the ordering of files in python 3 (I guess I'm using a set or something which is not ordered).

coveralls commented 10 years ago

Coverage Status

Coverage increased (+1.26%) when pulling 126487ab341ed315cec2570d129b8503c6a92c26 on add_bzr2 into bcfec0be0efec563e897289bde2f7fbc76ec367d on master.

coveralls commented 10 years ago

Coverage Status

Coverage increased (+1.26%) when pulling 126487ab341ed315cec2570d129b8503c6a92c26 on add_bzr2 into bcfec0be0efec563e897289bde2f7fbc76ec367d on master.