landscape (codeclimate)

hayd / pep8radius

PEP8 clean only the parts of the files touched since the last commit, a previous commit or (the merge-base of) a branch.

MIT License

183 stars 9 forks source link

landscape (codeclimate) #63

Closed hayd closed 10 years ago

hayd commented 10 years ago

https://landscape.io/github/hayd/pep8radius/

There's a couple of easy fixes here.

[x] Instance of 'Radius' has no... should use abc.@abstractmethod see http://stackoverflow.com/a/4382961/1240268 *
[x] The duck punching causes some smells, which I guess is expected...

* issue is that the python 2 and 3 syntax is different, see http://stackoverflow.com/a/18513858/1240268 but loath to add six as requirement (could plop into compat module in a refactor - the file is getting stupidly long!)

Ah ha, trick could be just to create class AbstractMethodError(NotImplementedError).

Update: meh on the remaining things... just meh.

schodge commented 10 years ago

Monkey patching! No violence to waterfowl!

Are you running this on the test file too? I didn't see it on the list.

hayd commented 10 years ago

I've not set up anything, just turned this one with a button click, so it's running what it's running! :). the temp/test files are generated and not in git, so probably that's why they don't appear. ?

hayd commented 10 years ago

@schodge just for you: https://github.com/hayd/pep8radius/commit/215a3017a5b13077f6a4b475a59b70e06b73860c

schodge commented 10 years ago

The monkey union has now let my kickback clear escrow, thank you.

Andy Hayden wrote:

@schodge https://github.com/schodge just for you: 215a301 https://github.com/hayd/pep8radius/commit/215a3017a5b13077f6a4b475a59b70e06b73860c

— Reply to this email directly or view it on GitHub https://github.com/hayd/pep8radius/issues/63#issuecomment-55482370.