hayd / pep8radius

PEP8 clean only the parts of the files touched since the last commit, a previous commit or (the merge-base of) a branch.
MIT License
183 stars 9 forks source link

Brute force remove files from temp that don't want to be removed. #65

Closed schodge closed 10 years ago

schodge commented 10 years ago

Fixes the git error in Issue #64.

Failure was due to files in temp being marked as read only. This http://stackoverflow.com/questions/1213706/what-user-do-python-scripts-run-as-in-windows was a nice start, but the individual files needed to be changed - doesn't appear there's a flag to do that, so manually walk the tree. http://stackoverflow.com/questions/7228296/permission-change-of-files-in-python

The cleaner way to do this is to define a function for rmtree to call on failure, but I only ever get this on the git directory and not the hg, so unless it pops up elsewhere this ugly little kludge should fix things.

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling 0abe0c5b009d41abaece0e93fa9c0d0df0a37562 on schodge:win_file_fix into 202251340dc1e90a4ecddcc56210f95f7dc0d30e on hayd:master.

schodge commented 10 years ago

Done.

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling 6106577fca6891b65cb56da98a5f76d548d08500 on schodge:win_file_fix into 202251340dc1e90a4ecddcc56210f95f7dc0d30e on hayd:master.

hayd commented 10 years ago

merged! apologies for the slowness. Will bump a release soon.