Feedback on config - Githubissues

hayd / pep8radius

PEP8 clean only the parts of the files touched since the last commit, a previous commit or (the merge-base of) a branch.

MIT License

183 stars 9 forks source link

Feedback on config #72

Closed hayd closed 9 years ago

hayd commented 10 years ago

At the moment it looks at default (home config) then updates with local configs (.pep8 etc) then updates with passed in arguments. See #71.

Was hoping for feedback before pushing release...

Concerns:

This may raise if there are bad config files. Personally I think this is a good thing.
If you are using a projects config perhaps you don't want to dirty it with your own? (currently if configs are not set locally then defaults are from the user's config). I'm unsure about this behaviour.

hayd commented 9 years ago

Thinking of changing API slightly (but will match whatever autopep8 decides), to have --global-config and --ignore-local-config for the following behaviour:

if --global-config use this path as global_config
else set global_config to DEFAULT_CONFIG
update parser with global_config (if file is missing this does nothing)
if not passed --ignore-local-config then update parser with local config (found with parent-tail in autopep8, just looking in root dir here)
update with passed in arguments