search

haydenwoodhead / burner.kiwi

No bullshit temporary mail service written in Go
https://burner.kiwi
MIT License
216 stars 26 forks source link

Add ability to request a custom address #13

Closed cdubz closed 5 years ago

cdubz commented 5 years ago

Following discussion in #6.

cdubz commented 5 years ago

Couple of css color things that I’m sure you’re aware of.

What are you thinking here? I intentionally kept things simple for this first pass.

[...] have you considered showing a pretty HTML error if the user asks to register an address that already exists?

Should I address that in this PR, or should there be a broader effort to make errors throughout the app prettier?

haydenwoodhead commented 5 years ago

Couple of css color things that I’m sure you’re aware of.

What are you thinking here? I intentionally kept things simple for this first pass.

Yeah sorry this was just to acknowledge that this was an initial thing and you weren't yet finished.

Should I address that in this PR, or should there be a broader effort to make errors throughout the app prettier?

This is a good point and something that is on the todo list. I also haven't researched any error displaying solutions. I think just a simple text error will be absolutely fine for the moment.

haydenwoodhead commented 5 years ago

@cdubz hey. Are you still interested in fixing those small things up? If not I'll merge this pr in as is and fix them.

cdubz commented 5 years ago

Let’s get this merged in. Sorry, short on time for a bit here.

haydenwoodhead commented 5 years ago

Let’s get this merged in. Sorry, short on time for a bit here.

No problem. Thanks for your help.