hayes / pothos

Pothos GraphQL is library for creating GraphQL schemas in typescript using a strongly typed code first approach
https://pothos-graphql.dev
ISC License
2.32k stars 158 forks source link

Add support to graphql@16.8.2+ #1222

Closed shadoworion closed 3 months ago

shadoworion commented 3 months ago

When installing graphql@16.8.2 - graphql@16.9.0, it breaks production deployment (aws elastic beanstalk):

2024/06/22 08:32:59.181449 [INFO] Using npm v10
2024/06/22 08:32:59.181463 [INFO] Running command: /bin/su webapp -c npm --omit=dev install
2024/06/22 08:33:15.860919 [INFO] npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: backend@1.0.0
npm ERR! Found: graphql@16.9.0
npm ERR! node_modules/graphql
npm ERR!   graphql@"16.9.0" from the root project
npm ERR!   peer graphql@">=15.1.0" from @pothos/core@3.41.1
npm ERR!   node_modules/@pothos/core
npm ERR!     @pothos/core@"3.41.1" from the root project
npm ERR!     peer @pothos/core@"*" from @pothos/plugin-prisma@3.65.2
npm ERR!     node_modules/@pothos/plugin-prisma
npm ERR!       @pothos/plugin-prisma@"3.65.2" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer graphql@"16.8.1" from @pothos/plugin-prisma@3.65.2
npm ERR! node_modules/@pothos/plugin-prisma
npm ERR!   @pothos/plugin-prisma@"3.65.2" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /home/webapp/.npm/_logs/2024-06-22T08_32_59_660Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /home/webapp/.npm/_logs/2024-06-22T08_32_59_660Z-debug-0.log
hayes commented 3 months ago

Thanks for reporting this. It looks like the peer dependency accidentally got locked to a specific version, that's definitely not what we want

hayes commented 3 months ago

releasing a fix for this now!