hayes0724 / shopify-packer

Modern development tool for Shopify using Webpack 5. Easy to extend and customize, zero build config, compatible with Slate and existing websites.
https://hayes0724.github.io/shopify-packer/
MIT License
181 stars 37 forks source link

packer start: handle {file}.css.liquid correctly #181

Closed danielbeardsley closed 2 years ago

danielbeardsley commented 2 years ago

somefile.css.liquid was being picked up as a "liquid" file and we assumed it definitely wasn't in the dist/assets dir. This is sometimes not true (we can have liquid files in the assets dir).

Since the paths we get are already relative to the assets dir, let's just use path joining and normalization to handle those cases. All this function can do is exclude some files, it can't move them. So we shouldn't be trying to create new paths based on extensions.

Fixes #144

What kind of change does this PR introduce? (check at least one)

Does this PR introduce a breaking change? (check one)

The PR fulfills these requirements:

Thanks for working with me on this @masonmcelvain