somefile.css.liquid was being picked up as a "liquid" file and we
assumed it definitely wasn't in the dist/assets dir. This is sometimes
not true (we can have liquid files in the assets dir).
Since the paths we get are already relative to the assets dir, let's
just use path joining and normalization to handle those cases. All this
function can do is exclude some files, it can't move them. So we
shouldn't be trying to create new paths based on extensions.
Fixes #144
What kind of change does this PR introduce? (check at least one)
[X] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Docs
[ ] Other, please describe:
Does this PR introduce a breaking change? (check one)
[ ] Yes
[X] No
The PR fulfills these requirements:
[X] It's submitted to the dev branch, not the master branch
somefile.css.liquid was being picked up as a "liquid" file and we assumed it definitely wasn't in the dist/assets dir. This is sometimes not true (we can have liquid files in the assets dir).
Since the paths we get are already relative to the assets dir, let's just use path joining and normalization to handle those cases. All this function can do is exclude some files, it can't move them. So we shouldn't be trying to create new paths based on extensions.
Fixes #144
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branchThanks for working with me on this @masonmcelvain