[BUG] --nodelete does not seem to work

hayes0724 / shopify-packer

Modern development tool for Shopify using Webpack 5. Easy to extend and customize, zero build config, compatible with Slate and existing websites.

https://hayes0724.github.io/shopify-packer/

MIT License

181 stars 37 forks source link

[BUG] --nodelete does not seem to work #60

Closed fcisio closed 3 years ago

fcisio commented 3 years ago

Describe the bug When doing packer deploy --nodelete, everything gets replaced by the build. So ignored files are deleted, this includes the settings_data.json

hayes0724 commented 3 years ago

Packer was not passing the no delete flag to themekit. I also created basic theme info output so you know what the settings are when you deploy

↑  Uploading to Shopify...
i Deploy Mode: noDelete
i Environment: live

Monolith-agency commented 3 years ago

@hayes0724 Sounds awesome! Thanks