search

hayes0724 / shopify-packer

Modern development tool for Shopify using Webpack 5. Easy to extend and customize, zero build config, compatible with Slate and existing websites.
https://hayes0724.github.io/shopify-packer/
MIT License
181 stars 37 forks source link

[BUG] Locale files are not uploading to Shopify #90

Open jzelaya-manduka opened 3 years ago

jzelaya-manduka commented 3 years ago

Describe the bug When using either packer start or packer watch, modifying existing locale files locally does not upload changes to the Shopify theme. New files added to the locales folder do not upload either.

To Reproduce Steps to reproduce the behavior:

  1. packer start
  2. make changes in en.default.json and save
  3. refresh the browser

Expected behavior "Uploading to Shopify..." should appear in the console and changes should be seen in the browser.

System (please complete the following information):

Packer (please complete the following information):

Theme (please complete the following information):

ghost commented 3 years ago

I have the same issue. Is there any update on this?

thebiggianthead commented 3 years ago

Looks like this is also true of settings_schema.json – looks like the command only looks for Liquid files being updated. Would likely be worth observing JSON files too, as these are changed frequently during theme development.