search

hayesgm / seacrest

WalletConnect over the terminal or GitHub Actions
MIT License
27 stars 6 forks source link

UX Improvements #2

Closed hayesgm closed 2 years ago

hayesgm commented 2 years ago

This patch adds two big UX improvements

  1. We add a retry concept where we generate a new URL from WalletConnect after 60 seconds. This fixes issues where the URI just "does nothing" after some time. a. Note: we keep "reshow" as a concept of printing out the old URL, which is important for being able to find the URL in the GitHub logs. b. We also add a max retry count so eventually we fail instead of trying forever.
  2. We add a "requested network" concept where you can request a given network and reject a connection if the network doesn't match. This should help prevent issues of the client connecting on the wrong network and causing confusion or errors in usage.

These code patches are a little weird, but I think overall the user experience improvements are worth the effort.