search

hayesgm / seacrest

WalletConnect over the terminal or GitHub Actions
MIT License
27 stars 6 forks source link

Use @walletconnect/client instead #6

Open pedrouid opened 2 years ago

pedrouid commented 2 years ago

Hey @hayesgm @kevincheng96, someone just showed me this repo 🙌

Glad to see this project honestly. I've always pictured WalletConnect being perfect for secure smart contract deployment

However I noticed that you are using a very old package @walletconect/node from a period where we used to split packages for react-native, browser and node.js

This no longer necessary and we describe it here: https://docs.walletconnect.com/legacy-clients

The main advantage is that at least it makes sure that you are using the latest changes.

While the main protocol client barely changed since then there is many underlying dependencies that have improved and reduced bundle size for example

Let us know if you need help from the WalletConnect team! 💪

hayesgm commented 2 years ago

Okay thanks; I can take a look- I was a little lost in the multiple client libaries and then in the upgrade to 2.0. I believe that 2.0 includes a more persistent connection type where you don't need to scan a QR code the next time you visit; is that correct? If so, do you think that could make sense for this kind of flow or do you think that the 1.0 flow is best? Happy to hop on an offline sync if you want to chat.