haykam821 / Mod-Viewer

Adds a server-side user interface for viewing loaded mods to Minecraft.
MIT License
9 stars 2 forks source link

Can be marked as 1.19.3 compatible, but... #5

Closed sternschnaube closed 11 months ago

sternschnaube commented 1 year ago

Hello, everything loads fine on 1.19.3. But I'm not sure if the names should be displayed like this. Other buttons having the internal names as well. And the button to change the view from Mods <> Libraries doesn't change his description if clicked to Libraries. It should say "Display Mods", but that's maybe more an improvement suggestion from my side.

EDIT: I saw right now that I get this spam error in the server console.

java.lang.NoSuchFieldError: field_15015 [02:39:41] [Server thread/INFO]: [STDERR]: at io.github.haykam821.modviewer.ui.element.ElementUtil.playClickSound(ElementUtil.java:15) [02:39:41] [Server thread/INFO]: [STDERR]: at io.github.haykam821.modviewer.ui.element.PageElement.lambda$createCallback$0(PageElement.java:41) [02:39:41] [Server thread/INFO]: [STDERR]: at eu.pb4.sgui.api.gui.SlotGuiInterface.click(SlotGuiInterface.java:31) [02:39:41] [Server thread/INFO]: [STDERR]: at net.minecraft.class_3244.handler$end000$sgui$handleGuiClicks(class_3244.java:20024) [02:39:41] [Server thread/INFO]: [STDERR]: at net.minecraft.class_3244.method_12076(class_3244.java:1657) [02:39:41] [Server thread/INFO]: [STDERR]: at net.minecraft.class_2813.method_12191(class_2813.java:58) [02:39:41] [Server thread/INFO]: [STDERR]: at net.minecraft.class_2813.method_11054(class_2813.java:13) [02:39:41] [Server thread/INFO]: [STDERR]: at net.minecraft.class_2600.method_11072(class_2600.java:22) [02:39:41] [Server thread/INFO]: [STDERR]: at net.minecraft.class_3738.run(class_3738.java:18) [02:39:41] [Server thread/INFO]: [STDERR]: at net.minecraft.class_1255.method_18859(class_1255.java:156) [02:39:41] [Server thread/INFO]: [STDERR]: at net.minecraft.class_4093.method_18859(class_4093.java:23) [02:39:41] [Server thread/INFO]: [STDERR]: at net.minecraft.server.MinecraftServer.method_24306(MinecraftServer.java:787) [02:39:41] [Server thread/INFO]: [STDERR]: at net.minecraft.server.MinecraftServer.method_18859(MinecraftServer.java:166) [02:39:41] [Server thread/INFO]: [STDERR]: at net.minecraft.class_1255.method_16075(class_1255.java:130) [02:39:41] [Server thread/INFO]: [STDERR]: at net.minecraft.server.MinecraftServer.method_20415(MinecraftServer.java:769) [02:39:41] [Server thread/INFO]: [STDERR]: at net.minecraft.server.MinecraftServer.method_16075(MinecraftServer.java:763) [02:39:41] [Server thread/INFO]: [STDERR]: at net.minecraft.class_1255.method_18857(class_1255.java:139) [02:39:41] [Server thread/INFO]: [STDERR]: at net.minecraft.server.MinecraftServer.method_16208(MinecraftServer.java:748) [02:39:41] [Server thread/INFO]: [STDERR]: at net.minecraft.server.MinecraftServer.handler$zja000$modifiedRunLoop(MinecraftServer.java:5917) [02:39:41] [Server thread/INFO]: [STDERR]: at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:655) [02:39:41] [Server thread/INFO]: [STDERR]: at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:264) [02:39:41] [Server thread/INFO]: [STDERR]: at java.base/java.lang.Thread.run(Thread.java:833)