haystack / YouPS

YouPS: An email automation tool that makes your email management easy! 😎
11 stars 5 forks source link

Current method of assigning names to contacts is incorrect #159

Closed lukesmurray closed 5 years ago

lukesmurray commented 5 years ago

https://github.com/soyapark/murmur/blob/26708af76df239a76fadd94305d1a6463bd59a0a/engine/models/folder.py#L578-L580

We have the incorrect assumption that each contact is associated with a single name. We really want each contact to be associated with multiple aliases. This could be implemented similar to the flags field but it would be nice to find a more correct way to do it, with a foreign key on an aliases table for example.

This change should also look at how the equality method is performed on contacts.