Relay server issue- missing message-id

haystack / YouPS

YouPS: An email automation tool that makes your email management easy! 😎

11 stars 5 forks source link

Relay server issue- missing message-id #171

Open soyapark opened 5 years ago

soyapark commented 5 years ago

I should figure out how our relay server is configured. It is currently overwritten to Gmail smtp in private.py. I don't know why we are using gmail smtp. Can we just use our relay server?? (I asked current murmur team, and current team members don't know why they've been using gmail..) i.e. we have no problem with sending confirmation emails and such: messages have message-id but no sender. emails sent using lamson: missing message-id, but sender is us

lukesmurray commented 5 years ago

i will try to come up with a workaround for the missing message-ids. regardless of how we send the emails we probably don't want to just ignore those messages. Other people may send emails with missing message-ids as well.

soyapark commented 5 years ago

@lukesmurray hmm I'm not sure about that. Most email messages have msg-ids. If it is missing, it is sent from malicious or untrusted servers which will be mostly spam and we can ignore most of cases.

soyapark commented 5 years ago

@lukesmurray I cancel what I said. I've been printing out msg-id of my incoming message and realize actually many messages are missing message-ids. Don't know what is the right answer for missing message-ids. A potential-problematic user flow is:

A user responds to a message (msg O) without message-id and let's call this response email as msg A.
When the user tries to look into msg A's thread (e.g. A.recent_messages) Youps couldn't find the connection between msg O and A since we don't have message-id of msg O.

lukesmurray commented 5 years ago

Ok so I figured out why this is happening and I'm working on a fix. SMTP servers do not always add the message id but we are free to create our own. I am basically going to hash a unique subset of the headers.