search

haystack / eyebrowse-chrome-ext

reviving eyebrowse
http://eyebrowse.csail.mit.edu/
MIT License
13 stars 7 forks source link

Bug with nagging + set nag limit #21

Closed joshblum closed 9 years ago

joshblum commented 9 years ago

Doesn't seem to be working properly

joshblum commented 9 years ago

@amyxzhang i think the problem was related to the keys we were setting in the nags hashmap. can you checkout locally and verify the bug is done? e358caf0ad1a7e55802c03e23c11f697a068b4e7

Regarding the nag code I kinda of like the model of either triggering a nag after a number of visits or a time threshold, perhaps we should just increase the number of overall visits required?(https://github.com/haystack/eyebrowse-chrome-ext/blob/master/js/main.js#L268)

karger commented 9 years ago

Agreed on a minimum threshold for nags. Or more generally, to not nag about "unimportant" sites if you are expecting to encounter and want to nag about important ones. But how do we know if you're going to encounter a more important site? Here's one heuristic: once you've decided it's time to nag, and nag about a site, allow yourself to nag about any "more important" site that is encountered thereafter (and then to nag about any site more important than that, etc.). Each time you nag the importance threshold will go up, so you're unlikely to do too many nags.

On 3/23/2015 8:42 PM, Joshua Blum wrote:

@amyxzhang https://github.com/amyxzhang i think the problem was related to the keys we were setting in the |nags| hashmap. can you checkout locally and verify the bug is done? e358caf https://github.com/haystack/eyebrowse-chrome-ext/commit/e358caf0ad1a7e55802c03e23c11f697a068b4e7

Regarding the nag code I kinda of like the model of either triggering a nag after a number of visits or a time threshold, perhaps we should just increase the number of overall visits required?(https://github.com/haystack/eyebrowse-chrome-ext/blob/master/js/main.js#L268)

— Reply to this email directly or view it on GitHub https://github.com/haystack/eyebrowse-chrome-ext/issues/21#issuecomment-85263355.

amyxzhang commented 9 years ago

I think we can do that (increase the visits for now) and we can re-evaluate later? I personally haven't found it to be bad but maybe I've white and blacklisted a lot of sites by now.

amyxzhang commented 9 years ago

just tried it out locally and it looks good to me.

joshblum commented 9 years ago

sweet. closing this, bumped up the limit to 15 visits before a nag (or if an hour has passed) with a10c2efb8305a2408fea0081622b6f5366f462d5 we can tweak as necessary