search

haystack / eyebrowse-chrome-ext

reviving eyebrowse
http://eyebrowse.csail.mit.edu/
MIT License
13 stars 7 forks source link

Raty Copied #86

Closed kifleW closed 5 years ago

amyxzhang commented 5 years ago

Hey @kifleW, I don't think we need all these files. Can you please remove everything except what's inside raty/lib? Also I'd like each type of file in their respective places (css file in eyebrowse-chrome-ext/css, js file in eyebrowse-chrome-ext/libs, img files in eyebrowse-chrome-ext/img (ideally in their own folder called raty, font files in eyebrowse-chrome-ext/fonts. This may mean that you need to update relative file paths in the code.

kifleW commented 5 years ago

raty/lib? It's lib/raty right? Also, I believe all the changed files are from raty and I removed a .gitmodules file that I created previously. I could move each type of file in their respective places, but yeah that may mean updating relative file paths in the code. Is it worth it?

amyxzhang commented 5 years ago

I mean raty/lib here: https://github.com/wbotelhos/raty/tree/master/lib See how all the files not inside /lib are useless to us (demo, spec, vendor, etc.)

Should just be a find and replace search query?

amyxzhang commented 5 years ago

If it's too hard, then just put raty/lib inside a folder called raty inside eyebrowse-chrome-ext/libs. Though I'd prefer to have the files split out like how it's currently done for the libraries we've imported, this way all images are served from /img etc.

kifleW commented 5 years ago

Lol. I get it now. Ok. I'll try doing this. I also wanted to look at a bug Soya mentioned before we merged anyhow.