amyxzhang
commented
6 years ago How do you know what people will do? People do all sorts of weird things, and it’s better to be robust. Anyway, the code for accepting any of these separators in a string is cleaner than what you have. You can replace the whole code block with one line with re.split().
On Tue, Oct 30, 2018 at 6:47 AM soyapark-kaist notifications@github.com wrote:
@soyapark-kaist commented on this pull request.
In engine/main.py https://github.com/haystack/murmur/pull/233#discussion_r229256839:
@@ -528,7 +528,11 @@ def add_members(group_name, emails, add_as_mods, user): membergroup = MemberGroup.objects.get(group=group, member=user) is_admin = membergroup.admin if is_public or is_admin:
- email_list = emails.strip().lower().split(',')
- emails_txt = emails.strip().lower()
- email_serators = [emails_txt.split(','), emails_txt.split(';'), emails_txt.split('|'), emails_txt.split('/')]
- email_serators_len = [len(x) for x in email_serators]
- seperator_index = email_serators_len.index(max(email_serators_len))
- email_list = email_serators[seperator_index]
Yes. That's intentional. People don't mix up the separators within one list of email addresses
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/haystack/murmur/pull/233#discussion_r229256839, or mute the thread https://github.com/notifications/unsubscribe-auth/ABPdyoDu1-9xWp7AGbyb86ZfKsoXAFcYks5uqC43gaJpZM4XyEUb .
-- Amy X. Zhang | Ph.D. student at MIT CSAIL | http://people.csail.mit.edu/axz | @amyxzh
soyapark-kaist
Resolve a bug which occurs at a following situation: when a user replies to the thread with an attachment, other users who is using apple mail can't see the previous conversation at the thread.