Remove squadbox code

[soyapark]

There are too many left-over codes from squadbox. It makes the code extra long and less-readable. For instance, I suspect gmail_setup folder is built for squadbox functionality (I tracked the changes) such as updating gmail filters.

[karger]

Rather than removing the squadbox code, I would prefer to consider ways to re-architect murmur so that tools like squadbox are easy extensions of it.  Note squadbox is still running, and there's a good chance we continue research/development in that direction.  Also, I've been talking to some people about a possible tool with some squadbox overlap that we may want to build on top of murmur.

On 7/3/2020 4:30 PM, Soya wrote:

There are too many left-over codes from squadbox. It makes the code extra long and less-readable. For instance, I suspect gmail_setup folder is built for squadbox functionality (I tracked the changes) such as updating gmail filters.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/haystack/murmur/issues/292, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIWSXUMTRQHFJZQ455UID3RZY5WJANCNFSM4OQBYTPA.

[soyapark]

There is a separate repo for squadbox. And currently, the codebase is simply a chain of if statements (i.e. if it is running murmur then do this function else do squadbox functions..) I'm not sure this structure provides much insight. Are you thinking in the future, if there is another app, then they just add another else if statement to the current code? When I started Youps codebase, I was actually trying the same approach like squadbox, adding another else if statement. However, I'm advised to spin off a new codebase and leave the murmur codebase as is. I think my code reviewer was worrying about the code base getting too big. I wonder why squadbox code can remain in the codebase when Youps can't?

On Fri, Jul 3, 2020 at 5:31 PM David Karger notifications@github.com wrote:

Rather than removing the squadbox code, I would prefer to consider ways to re-architect murmur so that tools like squadbox are easy extensions of it. Note squadbox is still running, and there's a good chance we continue research/development in that direction. Also, I've been talking to some people about a possible tool with some squadbox overlap that we may want to build on top of murmur.

On 7/3/2020 4:30 PM, Soya wrote:

There are too many left-over codes from squadbox. It makes the code extra long and less-readable. For instance, I suspect gmail_setup folder is built for squadbox functionality (I tracked the changes) such as updating gmail filters.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/haystack/murmur/issues/292, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAIWSXUMTRQHFJZQ455UID3RZY5WJANCNFSM4OQBYTPA .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/haystack/murmur/issues/292#issuecomment-653681238, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIAPBLFKITKEB47SYE5UULDRZZEXVANCNFSM4OQBYTPA .

[karger]

I think there's a lot of duplicated functionality in the various mailing list apps we're building.  it would be really nice if we could factor that out and reuse it instead of having to maintain it separately for all the apps?  Perhaps a shared library with seperate code for each project that uses the library?

On 7/3/2020 6:00 PM, Soya wrote:

There is a separate repo for squadbox. And currently, the codebase is simply a chain of if statements (i.e. if it is running murmur then do this function else do squadbox functions..) I'm not sure this structure provides much insight. Are you thinking in the future, if there is another app, then they just add another else if statement to the current code? When I started Youps codebase, I was actually trying the same approach like squadbox, adding another else if statement. However, I'm advised to spin off a new codebase and leave the murmur codebase as is. I think my code reviewer was worrying about the code base getting too big. I wonder why squadbox code can remain in the codebase when Youps can't?

On Fri, Jul 3, 2020 at 5:31 PM David Karger notifications@github.com wrote:

Rather than removing the squadbox code, I would prefer to consider ways to re-architect murmur so that tools like squadbox are easy extensions of it. Note squadbox is still running, and there's a good chance we continue research/development in that direction. Also, I've been talking to some people about a possible tool with some squadbox overlap that we may want to build on top of murmur.

On 7/3/2020 4:30 PM, Soya wrote:

There are too many left-over codes from squadbox. It makes the code extra long and less-readable. For instance, I suspect gmail_setup folder is built for squadbox functionality (I tracked the changes) such as updating gmail filters.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/haystack/murmur/issues/292, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AAIWSXUMTRQHFJZQ455UID3RZY5WJANCNFSM4OQBYTPA

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/haystack/murmur/issues/292#issuecomment-653681238, or unsubscribe

https://github.com/notifications/unsubscribe-auth/AIAPBLFKITKEB47SYE5UULDRZZEXVANCNFSM4OQBYTPA .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/haystack/murmur/issues/292#issuecomment-653685332, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIWSXTIXBII37WTILODIR3RZZIHJANCNFSM4OQBYTPA.