search

haystack / murmur

A mailing list designed to reduce noise and encourage sharing
25 stars 13 forks source link

Upgraded from Bootstrap v3.2 to v4.5 #309

Closed raxelg closed 3 years ago

raxelg commented 3 years ago

I had to fix the NavBar, some spacing, the member, admin, and mod labels. Also fixed the glyphicon issue with Members List and in Explore Groups by using Bootstrap check icon.

I'm think the glyphicon files can be deleted but wanted to confirm.

soyapark commented 3 years ago

Hi @raxelg , the new bootstrap looks much cleaner than previous version! Thanks for the great work!

One thing I want to ask you is, I'm not sure if it's happening at your browser but it looks like at the homepage, if the input has a long label the input and label are not stick next to each other with this newer bootstrap: image For example, "Email address:" and "Password (again)" has input at the next line.

raxelg commented 3 years ago
Screen Shot 2020-08-22 at 4 31 49 PM

I can't reproduce the issue on my end but I looked at the code and it seems it's HTML from Django authentication forms. I can customize the form in a way I think that shouldn't happen but I won't be able to test it. I changed how home.html looks by just accessing the input fields in the AuthenticationForm and RegistrationForm and using my own labels.