search

haystack / murmur

A mailing list designed to reduce noise and encourage sharing
25 stars 13 forks source link

Creating tag tokens in tag input field using enter/tag keys #315

Closed raxelg closed 3 years ago

soyapark commented 3 years ago

I see referring the FollowTag model even if it is not defined in models.py https://github.com/haystack/murmur/blob/8029434f31c5ce498142dde7a928142be7a1e792/engine/main.py#L1515-L1542

Can you take a look at this code?

raxelg commented 3 years ago

The code is currently not affecting the determination of the recipients of emails because I changed that part of the backend. The FollowTag model is removed since it's simply the set difference between Tags and MuteTags for the followed tags so I thought an extra model would be unnecessary. However, the code you sent is being used in the posts page with the buttons below:

Screen Shot 2020-12-15 at 10 26 29 AM

I think we haven't decided what's the best way to have subscription on that page yet but I think the code that's been used there wasn't working either way so we could potentially refactor it or remove it. The follow_tag and unfollow_tag functions are used more throughout the codebase so it would be something that will require more time to go through even though it doesn't affect the functionality of the emails being sent based on tagging subscriptions in the settings page.

soyapark commented 3 years ago

Ah that makes sense. Thanks for clarification!