search

haystack / nb

12 stars 10 forks source link

Some features of converted PDFs do not render as text #127

Closed mfacciotti closed 3 years ago

mfacciotti commented 3 years ago

It seems as though some elements of PDFs are not converted into text but rather preserved in non-highlightable format. For example the title and authors in PDF <El Karoui et al. - 2019 - Future Trends in Synthetic Biology—A Report> are links in the original PDF. THat's great but when preserved makes them non-highlightable.

Figures are also not easy to highlight - but that was a given.

Not sure what the right solution should look like.

lihelennn commented 3 years ago

Interesting...yeah it may be that our PDF converter converts them to links and not text, so NB highlights can't pick them up. Do you have any screenshots on this?

@JumanaFM and I have also realized that things haven't been working well on Safari, so that might be another reason why. We're going to be putting out a fix ASAP but might not be before your class starts, so it'd be great if you can use Chrome for now. Any screenshots here would be super helpful! Thanks :)

mfacciotti commented 3 years ago

In the case I've seen, they are links in the PDF. The converter is keeping them as links (which would be the intuitive thing to do). In the context of NB, however, it feels strange to not be able to select text.

JumanaFM commented 3 years ago

Hopefully now it works on Safari. Thanks, Helen!