karger
commented
2 years ago depending on implementation complexity, we might want to keep every client listening to the broadcast, and let each client decide whether it wants to pay attention depending on the broadcast. Otherwise the server will have to keep track of each client's state---what document they are on etc.
On 11/11/2021 5:07 PM, Jumana Almahmoud wrote:
Currently, Socket.io is broadcasting to all readings in all classes and filters on the client-side. This introduces problems, including filtering (new annotations, replies, etc.) for sections. As a result, users in all sections in the class gets notified when new annotations or replies happen (even if it's from other sections)
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/haystack/nb/issues/199, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIWSXWNZHZ5YAW22HWKKN3ULQ5B5ANCNFSM5H3OMMAA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
Currently, Socket.io is broadcasting to all readings in all classes and filters on the client-side. This introduces problems, including filtering (new annotations, replies, etc.) for sections. As a result, users in all sections in the class gets notified when new annotations or replies happen (even if it's from other sections)