Closed JumanaFM closed 1 year ago
I thought we had a mechanism to switch someone between student and instructor status. can't that just be broadened to switch between the three different types? That's much simpler than separate remove and add.
On 2/10/2023 5:35 PM, Jumana Almahmoud wrote:
Add TA
Similar to adding an instructor, you can add TA by selecting TA. If the user already exists, remove it from the class first, then add it (All previous comments and interactions for this user are preserved and will be shown as a TA).
TA vs Student
TA and Student share the same privileges except for the following:
- TA has a flag (icon) next to its comments and replies.
TA can escalate comments to instructor
Escalation workflow
- TA can escalate a comment by clicking the reply request icon. image https://user-images.githubusercontent.com/22763091/218210899-59e08cee-801f-417f-9224-d74380160ee9.png
- Instructor can see all pending requests by filtering using "Pending TA reply requests". image https://user-images.githubusercontent.com/22763091/218209463-e9f1d599-b65c-4e07-87c2-66ede424f23c.png
- Instructor can resolve the request by replying to the comment.
- After the instructor reply, the request will be removed immediately from the pending requests.
Closes #271 https://github.com/haystack/nb/issues/271 Closes #37 https://github.com/haystack/nb/issues/37
You can view, comment on, or merge this pull request online at:
https://github.com/haystack/nb/pull/272
Commit Summary
cffa6ec https://github.com/haystack/nb/pull/272/commits/cffa6ec460fff42f4ef12261f064cd293342f5c8 Add TA role
File Changes
(10 files https://github.com/haystack/nb/pull/272/files)
A migrations/20230210083201-edit-nb-log-role-enum.js https://github.com/haystack/nb/pull/272/files#diff-89b29f1d4b2757eba4e2f83c4c2202a879a26b79eccf530d0a61638538503d44 (11)
A migrations/20230210083349-edit-spotlight-log-role-enum.js https://github.com/haystack/nb/pull/272/files#diff-15fef92d3c52dd6ccaf8774f47927cc6a006ff69f2f7eeb0377f8911b62dbdbb (11)
A migrations/20230210194915-insert-nb-configs-11.js https://github.com/haystack/nb/pull/272/files#diff-8032dd4bf65967916e9e2764c420ea6d14b3d1be25d430be2be4c7b30ab9983f (17)
M models/utils.js https://github.com/haystack/nb/pull/272/files#diff-8165fc63713850457f5f5dcab4355ef2ede435db8ce6fb0034f0af7b6d4477e0 (8)
M routes/annotations.js https://github.com/haystack/nb/pull/272/files#diff-6f9d81bffd82638602f9b8475c1d1fb7be88ac6144a360dab32dc325623072a4 (64)
M routes/classes.js https://github.com/haystack/nb/pull/272/files#diff-734fc3782b383b429f39ec1c79ff2c8aca763891d27e243041fd2b79fc7e6d2f (86)
M src/components/course/CourseDashboard.vue https://github.com/haystack/nb/pull/272/files#diff-58f01bd0ff8d6e14759da5380bb013bc656ec44a6268d337fa5db00e6aa217cb (607)
M src/components/course/CourseUsers.vue https://github.com/haystack/nb/pull/272/files#diff-1a11268bbdf0dc8bcd70e6b198d95bf31192c4f585d23ef3884b393ee7ec26c3 (26)
M src/components/sidebar/CourseList.vue https://github.com/haystack/nb/pull/272/files#diff-6815b80321330630e72c5898649fb62c9bd63fe4b35654a83ac2056aaf3d1bf2 (57)
M src/views/DashboardPage.vue https://github.com/haystack/nb/pull/272/files#diff-a41dce3c83c009ba1a402ad15f35608de49c80ee1907fa4a8a35a8d770ea79df (23)
Patch Links:
— Reply to this email directly, view it on GitHub https://github.com/haystack/nb/pull/272, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIWSXS475A7W75HJCGF34DWW27EXANCNFSM6AAAAAAUYJRPBA. You are receiving this because you are subscribed to this thread.Message ID: @.***>
@karger it’s on our issue list and it’s still pending https://github.com/haystack/nb/issues/43 i marked it as “UROP”, and “Good first issue”
Add TA
Similar to adding an instructor, you can add TA by selecting TA. If the user already exists, remove it from the class first, then add it (All previous comments and interactions for this user are preserved and will be shown as a TA).
TA vs Student
TA and Student share the same privileges except for the following:
Escalation workflow
Closes #271 Closes #37