search

haystack / nb

12 stars 10 forks source link

Handle pages that don't have annotations #89

Closed JumanaFM closed 3 years ago

JumanaFM commented 3 years ago

currently we always get the loading screen even if there is no comments or annotations on the page image

Maybe we can simply just hide that loading if no annotations are there.

Also, can we change the text "Gathering any class annotations" to something generic like "Fetching Annotations"

Thank you so much for your contribution Helen! I'm assigning this to you as this is related to #83

lihelennn commented 3 years ago

@JumanaFM Thanks for this comment! I've put out a PR on nbclient for this https://github.com/haystack/nbclient/pull/10